Skip to content

Conversation

@fatmcgav
Copy link

@fatmcgav fatmcgav commented Oct 15, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This commit updates the manifest/morph/scaffold.go logic in order to
resolve a panic encountered when working with Tuple types.

Also adds a new unit test to cover this case.

Disclaimer: This fix and the coresponding test case was generated by
Gemini, and has been reviewed and tested by myself.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ cd manifest
$ make testacc TESTARGS="-run ^TestKubernetesManifest_StrategicPatch"
go test -count=1 -tags acceptance "./test/acceptance" -v -run ^TestKubernetesManifest_StrategicPatch -timeout 120m
2025/10/15 17:06:15 Testing against Kubernetes API version: v1.34.0
=== RUN   TestKubernetesManifest_StrategicPatch
--- PASS: TestKubernetesManifest_StrategicPatch (8.37s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/manifest/test/acceptance     8.815s

Release Note

Release note for CHANGELOG:

fix: Resolve issue with provider crashing the `kubernetes_manifest` resource when working with complex manifests

References

Fixes: #2778 #2754 plus probably others...

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@fatmcgav fatmcgav requested a review from a team as a code owner October 15, 2025 15:36
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Oct 15, 2025

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Gavin Williams seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

This commit updates the `manifest/morph/scaffold.go` logic in order to
resolve a panic encountered when working with `Tuple` types.

Also adds a new unit test to cover this case.

Disclaimer: This fix and the coresponding test case was generated by
Gemini, and has been reviewed and tested by myself.

Fixes: hashicorp#2778 hashicorp#2754 plus probably others...
@fatmcgav fatmcgav force-pushed the fix-provider-crash-elementkeyint0 branch from 6743340 to 78dd4c9 Compare October 17, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ElementKeyInt(0): can't use tftypes.Object["description":tftypes.String, "displayName":tftypes.String,

1 participant